Bug 129508 – Make UIViews for compositing layers in the UI process on iOS

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Make UIViews for compositing layers in the UI process on iOS

[Simon Fraser (smfr)]

Created attachment 225492 [details]
Patch

[Sam Weinig]

Comment on attachment 225492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225492&action=review

> Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm:41
> +- (void)setSubviews:(NSArray *)subviews;

This should be _web_setSubviews: (Says the council of 2).

> Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm:54
> +@implementation UIView (WKUIViewUtilities)
> +- (void)setSubviews:(NSArray *)subviews
> +{
> +    for (UIView* subview in self.subviews)
> +        [subview removeFromSuperview];
> +
> +    for (UIView* view in subviews)
> +        [self addSubview:view];
> +}
> +@end
> +#endif

Please add leading/trailing newlines.

> Source/WebKit2/UIProcess/ios/RemoteLayerTreeHostIOS.mm:109
> +    // FIXME: do through the view.
> +    [[layerOrView layer] web_disableAllActions];

Capital D in do!

> Source/WebKit2/UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm:48
> +    for (auto& it : stateTree.nodeMap()) {
> +        ScrollingStateNode* currNode = it.value;

You can do for (auto& currentNode : stateTree.nodeMap().values())

> Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm:117
> +}
> +
> +    
> +} // namespace WebKit

Too many lines!!!!!!!

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/164890