| Summary: | Make UIViews for compositing layers in the UI process on iOS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, dino, sam, simon.fraser, thorton | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2014-02-28 14:43:43 PST
Created attachment 225492 [details]
Patch
Comment on attachment 225492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225492&action=review > Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm:41 > +- (void)setSubviews:(NSArray *)subviews; This should be _web_setSubviews: (Says the council of 2). > Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm:54 > +@implementation UIView (WKUIViewUtilities) > +- (void)setSubviews:(NSArray *)subviews > +{ > + for (UIView* subview in self.subviews) > + [subview removeFromSuperview]; > + > + for (UIView* view in subviews) > + [self addSubview:view]; > +} > +@end > +#endif Please add leading/trailing newlines. > Source/WebKit2/UIProcess/ios/RemoteLayerTreeHostIOS.mm:109 > + // FIXME: do through the view. > + [[layerOrView layer] web_disableAllActions]; Capital D in do! > Source/WebKit2/UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm:48 > + for (auto& it : stateTree.nodeMap()) { > + ScrollingStateNode* currNode = it.value; You can do for (auto& currentNode : stateTree.nodeMap().values()) > Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm:117 > +} > + > + > +} // namespace WebKit Too many lines!!!!!!! |