Bug 129472

Summary:

[iOS][WK2] highlight rects should never big bigger than the view

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	enrica: review+

Description Benjamin Poulain 2014-02-28 00:29:47 PST

[iOS][WK2] highlight rects should never big bigger than the view

Comment 1 Benjamin Poulain 2014-02-28 00:31:04 PST

Created attachment 225443 [details]
Patch

Comment 2 Enrica Casucci 2014-02-28 15:03:09 PST

Comment on attachment 225443 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225443&action=review

Looks good to me.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:296
> +static inline bool highlightedQuadsFitInRect(const Vector<FloatQuad>& quads, const FloatRect& rect)

maybe isHighlightQuadSmaller ?

Comment 3 Benjamin Poulain 2014-02-28 15:50:12 PST

Committed r164892: <http://trac.webkit.org/changeset/164892>