Bug 129465 – :active style is not cleared when its display property is set to none before mouse released.

• Component: CSS
• Status: RESOLVED FIXED

[Sanghyup Lee]

We currently clearing the :active style when element has a renderer.
This patch makes elements active style without renderer cleared.

[Sanghyup Lee]

Created attachment 225433 [details]
Patch

[Andreas Kling]

Comment on attachment 225433 [details]
Patch

It's great that you are fixing this bug, but we should add a layout test so it doesn't regress again.
http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree

[Sanghyup Lee]

Created attachment 225542 [details]
Patch

[Darin Adler]

Comment on attachment 225542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225542&action=review

> Source/WebCore/dom/Document.cpp:5839
> +        if (!oldActiveElement->renderer())
> +            oldActiveElement->setActive(false);

This code change seems like only a partial fix. Last time Document::updateHoverActiveState was called, we called setActive(true) on multiple elements. It seems that elements that were ancestors of the main active one will have the same bug as before. We should construct test cases that cover that and fix the whole problem instead of patching over the most obvious surface part of the problem.

There’s no real need for the !oldActiveElement->renderer() check. It would be harmless and clearer to call oldActiveElement->setActive(false) unconditionally. It’s hard to understand why we would do this only for an element without a renderer.

Slightly ugly to fetch the renderer twice, here and for the loop just below it.

[Sanghyup Lee]

Created attachment 225580 [details]
Patch

[Antonio Gomes]

Comment on attachment 225580 [details]
Patch

r=me

[Gyuyoung Kim]

Comment on attachment 225580 [details]
Patch

cq=me. It looks latest patch is fixed according to Darin's comment.

[WebKit Commit Bot]

Comment on attachment 225580 [details]
Patch

Clearing flags on attachment: 225580

Committed r165037: <http://trac.webkit.org/changeset/165037>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.