Summary: | Clean up Heap::collect and Heap::markRoots | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Hahnenberg <mhahnenberg> | ||||||
Component: | JavaScriptCore | Assignee: | Mark Hahnenberg <mhahnenberg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ossy | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Mark Hahnenberg
2014-02-27 16:46:30 PST
Created attachment 225430 [details]
Patch
Comment on attachment 225430 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225430&action=review r=me > Source/JavaScriptCore/heap/Heap.cpp:483 > +void Heap::markProtectedObjects(HeapRootVisitor& heapRootVisitor) "visit"? > Source/JavaScriptCore/heap/Heap.cpp:493 > +void Heap::markTempSortVectors(HeapRootVisitor& heapRootVisitor) "visit"? > Source/JavaScriptCore/heap/Heap.cpp:513 > +void Heap::markArgumentBuffers(HeapRootVisitor& visitor) "visit"? > Source/JavaScriptCore/heap/Heap.cpp:637 > + SamplingRegion samplingRegion("Garbage Collection: Tracing"); "Marking"? Committed r164862: <http://trac.webkit.org/changeset/164862> Comment on attachment 225430 [details]
Patch
Clearing review flag.
Comment on attachment 225430 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225430&action=review > Source/JavaScriptCore/heap/Heap.cpp:667 > +#if ENABLE(GGC) > + Vector<const JSCell*> rememberedSet(m_slotVisitor.markStack().size()); > + m_slotVisitor.markStack().fillVector(rememberedSet); > +#endif rememberedSet is defined inside ENABLE(GGC) guard ... > Source/JavaScriptCore/heap/Heap.cpp:689 > + clearRememberedSet(rememberedSet); ... but used outside. And it broke the !ENABLE(GGC) builds. (In reply to comment #5) > (From update of attachment 225430 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=225430&action=review > > > Source/JavaScriptCore/heap/Heap.cpp:667 > > +#if ENABLE(GGC) > > + Vector<const JSCell*> rememberedSet(m_slotVisitor.markStack().size()); > > + m_slotVisitor.markStack().fillVector(rememberedSet); > > +#endif > > rememberedSet is defined inside ENABLE(GGC) guard ... > > > Source/JavaScriptCore/heap/Heap.cpp:689 > > + clearRememberedSet(rememberedSet); > > ... but used outside. And it broke the !ENABLE(GGC) builds. Good point, fix coming. Reopening to attach new patch. Created attachment 225473 [details]
Patch
Comment on attachment 225473 [details]
Patch
Since this fixes a build, it doesn't need review but feel free to comment :-)
Comment on attachment 225473 [details] Patch Bah, commit queue will take too long. Landed manually in r164864. Closing. |