Summary: | Web Replay: add infrastructure for auto-memoizing nondeterministic DOM APIs | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||||||||
Component: | DOM | Assignee: | BJ Burg <bburg> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | cdumez, cgarcia, commit-queue, ddkilzer, joepeck, kling, timothy | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
BJ Burg
2014-02-27 13:49:54 PST
Created attachment 225844 [details]
WIP patch
Created attachment 226076 [details]
the complete patch
Attachment 226076 [details] did not pass style-queue:
ERROR: Source/WebCore/replay/MemoizedDOMResult.h:117: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/replay/ReplayInputTypes.cpp:42: Wrong number of spaces before statement. (expected: 4) [whitespace/indent] [4]
Total errors found: 2 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 226077 [details]
bad attachment
I also attached the IDL changes I used to test the build and the various cases the code generator has to support for WEB_REPLAY and vanilla builds. The IDL changes won't be included in this patch, since they need separate testing.
Created attachment 226078 [details]
IDL changes
Created attachment 226079 [details]
sample generated code
Comment on attachment 226076 [details] the complete patch View in context: https://bugs.webkit.org/attachment.cgi?id=226076&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2208 > + push(@implContent, " }\n"); I'd add another \n here to give breathing room between the blocks. > Source/WebCore/replay/MemoizedDOMResult.cpp:76 > + encodedValue.put<String>("attribute", input.attribute()); These strings passed to put and get should use ASCIILiteral(). Comment on attachment 226076 [details] the complete patch View in context: https://bugs.webkit.org/attachment.cgi?id=226076&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3548 > + push(@implContent, $indent . "if (!cursor.isReplaying())\n"); > + push(@implContent, $indent . " $functionString;\n"); Shouldn't this also setDOMException if raises exception inside this if block? Committed r165521: <http://trac.webkit.org/changeset/165521> |