Bug 129442 – Updating some WebRTC and MediaStream LayoutTests

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Thiago de Barros Lacerda]

Due to changes in JavaScriptCore (in r163562), some LayoutTests in fast/mediastream needed to be updated.

[Thiago de Barros Lacerda]

Created attachment 225402 [details]
Patch

[Eric Carlson]

Comment on attachment 225402 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225402&action=review

> LayoutTests/fast/mediastream/RTCIceCandidate.html:-25
> -            shouldNotThrow('initializer = JSON.parse(JSON.stringify(candidate));');
> -
> -            shouldNotThrow('candidate = new RTCIceCandidate(initializer);');
> -            shouldBe('candidate.candidate', '"foo"');
> -            shouldBe('candidate.sdpMid', '"bar"');
> -            shouldBe('candidate.sdpMLineIndex', '6');
> -

ChangeLog should mention why this test was changed.

> LayoutTests/fast/mediastream/RTCSessionDescription.html:-24
> -            shouldNotThrow('initializer = JSON.parse(JSON.stringify(sessionDescription));');
> -
> -            shouldNotThrow("sessionDescription = new RTCSessionDescription(initializer);");
> -            shouldBe('sessionDescription.type', '"offer"');
> -            shouldBe('sessionDescription.sdp', '"foobar"');
> -

Ditto.

[Thiago de Barros Lacerda]

Created attachment 225456 [details]
Changes in ChangeLog

[Thiago de Barros Lacerda]

Created attachment 225469 [details]
Changes in ChangeLog

[Eric Carlson]

Comment on attachment 225469 [details]
Changes in ChangeLog

Thanks for the update!

[WebKit Commit Bot]

Comment on attachment 225469 [details]
Changes in ChangeLog

Clearing flags on attachment: 225469

Committed r164941: <http://trac.webkit.org/changeset/164941>