Summary: | Updating some WebRTC and MediaStream LayoutTests | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Thiago de Barros Lacerda <thiago.lacerda> | ||||||||
Component: | Tools / Tests | Assignee: | Thiago de Barros Lacerda <thiago.lacerda> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, glenn, hta, jer.noble, philipj, sergio, tommyw | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 124288 | ||||||||||
Attachments: |
|
Description
Thiago de Barros Lacerda
2014-02-27 12:45:44 PST
Created attachment 225402 [details]
Patch
Comment on attachment 225402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225402&action=review > LayoutTests/fast/mediastream/RTCIceCandidate.html:-25 > - shouldNotThrow('initializer = JSON.parse(JSON.stringify(candidate));'); > - > - shouldNotThrow('candidate = new RTCIceCandidate(initializer);'); > - shouldBe('candidate.candidate', '"foo"'); > - shouldBe('candidate.sdpMid', '"bar"'); > - shouldBe('candidate.sdpMLineIndex', '6'); > - ChangeLog should mention why this test was changed. > LayoutTests/fast/mediastream/RTCSessionDescription.html:-24 > - shouldNotThrow('initializer = JSON.parse(JSON.stringify(sessionDescription));'); > - > - shouldNotThrow("sessionDescription = new RTCSessionDescription(initializer);"); > - shouldBe('sessionDescription.type', '"offer"'); > - shouldBe('sessionDescription.sdp', '"foobar"'); > - Ditto. Created attachment 225456 [details]
Changes in ChangeLog
Created attachment 225469 [details]
Changes in ChangeLog
Comment on attachment 225469 [details]
Changes in ChangeLog
Thanks for the update!
Comment on attachment 225469 [details] Changes in ChangeLog Clearing flags on attachment: 225469 Committed r164941: <http://trac.webkit.org/changeset/164941> |