Bug 129435

Summary: Octane/closure thrashes between flattening dictionaries during global object initialization in a global eval
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: REOPENED    
Severity: Normal CC: barraclough, commit-queue, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, ossy, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 129490, 129699    
Bug Blocks:    
Attachments:
Description Flags
the patch oliver: review+

Filip Pizlo
Reported 2014-02-27 09:42:01 PST
If the global object is already a dictionary even before we start adding things, then we should leave it that way.
Attachments
the patch (5.89 KB, patch)
2014-02-27 09:44 PST, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-02-27 09:44:17 PST
Created attachment 225386 [details] the patch
Filip Pizlo
Comment 2 2014-02-27 10:29:08 PST
Landed in http://trac.webkit.org/changeset/164812
Csaba Osztrogonác
Comment 3 2014-02-28 08:59:46 PST
(In reply to comment #2) > Landed in http://trac.webkit.org/changeset/164812 It caused regression on 32 bit platforms, see https://bugs.webkit.org/show_bug.cgi?id=129490 for details.
WebKit Commit Bot
Comment 4 2014-03-04 13:22:41 PST
Re-opened since this is blocked by bug 129699
Note You need to log in before you can comment on or make changes to this bug.