| Summary: | Give VisitedLinkProviders an identifier and send them to the web process | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Anders Carlsson
2014-02-26 15:24:55 PST
Created attachment 225308 [details]
Patch
Attachment 225308 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKVisitedLinkProviderInternal.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 225308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225308&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKVisitedLinkProviderInternal.h:37 > + RefPtr<WebKit::VisitedLinkProvider> _visitedLinkProvider; Please keep this ivar in the implementation file until there’s a reason to expose it (and then use @package). > Source/WebKit2/UIProcess/VisitedLinkProvider.cpp:44 > + static uint64_t identifier; > + > + return ++identifier; Since clients can call -[WKVisitedLinkProvider init] from any thread, this needs to be made thread-safe. Committed r164756: <http://trac.webkit.org/changeset/164756> |