Bug 129398

Summary: Prepare for overflow scrolling nodes in the scrolling tree
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, cmarcelo, commit-queue, dino, esprehn+autocc, glenn, jamesr, kondapallykalyan, luiz, simon.fraser, thorton, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Description Simon Fraser (smfr) 2014-02-26 15:01:08 PST 
Prepare for overflow scrolling nodes in the scrolling tree
Comment 1 Simon Fraser (smfr) 2014-02-26 15:06:29 PST 
Created attachment 225303 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-02-26 16:28:46 PST 
Created attachment 225320 [details]
Patch
Comment 3 Tim Horton 2014-02-26 16:33:38 PST 
Comment on attachment 225320 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225320&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:3493
> +        else
> +            ASSERT_NOT_REACHED();

I think you want curly braces here

> Source/WebCore/rendering/RenderLayerCompositor.h:408
> +        FixedOrSticky = 1 << 0,

ViewportConstrained? :D
Comment 4 Tim Horton 2014-02-26 16:34:18 PST 
(In reply to comment #3)
> (From update of attachment 225320 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=225320&action=review
> 
> > Source/WebCore/rendering/RenderLayerCompositor.cpp:3493
> > +        else
> > +            ASSERT_NOT_REACHED();
> 
> I think you want curly braces here

Or maybe it's fine?
Comment 5 Simon Fraser (smfr) 2014-02-26 16:59:17 PST 
https://trac.webkit.org/r164759