Bug 12939
| Summary: | npfunctions.h has declarations for NP_ entrypoints that don't match npupp.h | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Rudi Sherry <rsherry> |
| Component: | Plug-ins | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, rniwa |
| Priority: | P2 | ||
| Version: | 412.x | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
Rudi Sherry
In npupp.h, which is what has been used to build plug-ins for a while, the declarations for the entrypoints for the exported functions have OSCALL in front of them which translates to WINAPI on windows, which means Pascal. All netscape plug-ins current on windows (including Acrobat's) are compiled with this.
In the WebKit, in WebKit/Plugins/npfunctions.h, there is no modifier to the declaration for the entrypoint types, so the compiler thinks they're cdecl. This works on all platforms except windows, where the stack pointer gets messed up.
We need to create a macro that resolves to WINAPI on Windows and nothing on other platforms and put them into this declaration.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
NPAPI support is gone since Safari 14 and npfunctions.h is also removed as part of following commit.
https://github.com/WebKit/WebKit/commit/043ef2367e62a2cc7e9facb1bdc42b0867b8dd6d
I think this can be marked as "RESOLVED WONTFIX". Thanks!