Bug 129383

Summary: Web Inspector: DataGrid columns should be objects not Maps
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Brian Burg <burg>
Status: RESOLVED FIXED    
Severity: Normal CC: burg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch none

Timothy Hatcher
Reported 2014-02-26 12:48:57 PST
DataGrid recently started using Map for the objects in DataGrid.columns. These should be Object instead of Map. JSC can JIT property access to objects, but not Map. We can use bracket notation if strings are more desirable, though I don't know if JSC can JIT those as well as fully qualified identifiers.
Attachments
the patch (16.27 KB, patch)
2014-04-29 10:17 PDT, Brian Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-02-26 12:50:34 PST
<rdar://problem/16176134>
Timothy Hatcher
Comment 2 2014-03-12 11:43:58 PDT
*** Bug 130035 has been marked as a duplicate of this bug. ***
Brian Burg
Comment 3 2014-04-29 10:17:55 PDT
Created attachment 230387 [details] the patch
WebKit Commit Bot
Comment 4 2014-04-29 13:52:19 PDT
Comment on attachment 230387 [details] the patch Clearing flags on attachment: 230387 Committed r167955: <http://trac.webkit.org/changeset/167955>
WebKit Commit Bot
Comment 5 2014-04-29 13:52:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.