Bug 129383

Summary:

Web Inspector: DataGrid columns should be objects not Maps

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Brian Burg <burg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

burg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	none

Description Timothy Hatcher 2014-02-26 12:48:57 PST

DataGrid recently started using Map for the objects in DataGrid.columns. These should be Object instead of Map. JSC can JIT property access to objects, but not Map.

We can use bracket notation if strings are more desirable, though I don't know if JSC can JIT those as well as fully qualified identifiers.

Comment 1 Radar WebKit Bug Importer 2014-02-26 12:50:34 PST

<rdar://problem/16176134>

Comment 2 Timothy Hatcher 2014-03-12 11:43:58 PDT

*** Bug 130035 has been marked as a duplicate of this bug. ***

Comment 3 Brian Burg 2014-04-29 10:17:55 PDT

Created attachment 230387 [details]
the patch

Comment 4 WebKit Commit Bot 2014-04-29 13:52:19 PDT

Comment on attachment 230387 [details]
the patch

Clearing flags on attachment: 230387

Committed r167955: <http://trac.webkit.org/changeset/167955>

Comment 5 WebKit Commit Bot 2014-04-29 13:52:22 PDT

All reviewed patches have been landed.  Closing bug.