Summary: | ASSERTION FAILED: m_heap->vm()->currentThreadIsHoldingAPILock() in inspector-protocol/* | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
Component: | Web Inspector | Assignee: | Mark Lam <mark.lam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, mark.lam, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2014-02-25 22:49:53 PST
Actually, there are lots of inspector tests failing with this assertion, probably should file a bug about each one. Also: inspector-protocol/debugger/nested-inspectors.html inspector-protocol/dom-debugger/node-removed.html (In reply to comment #2) > Actually, there are lots of inspector tests failing with this assertion, probably should file a bug about each one. > > Also: > > inspector-protocol/debugger/nested-inspectors.html > inspector-protocol/dom-debugger/node-removed.html They are probably due to the same root cause though. I'm investigating. *** Bug 129360 has been marked as a duplicate of this bug. *** The test failure is intermittent because it depends on an GC / allocation activity happening at exactly the right moment. That is why I don't see the failures when I run it on my machine. However, there is an easy way to get an equivalent reproduction case i.e. by adding the following assertion to JSC::Structure::create(): ASSERT(vm.currentThreadIsHoldingAPILock()); With that I can get the inspector-protocol tests to fail all the time. The failure is because InjectedScriptModule::ensureInjected() isn't using an APIEntryShim before it started calling functions that enter the VM. The fix is to use the shim here. Patch coming soon. Created attachment 225235 [details]
the patch.
Created attachment 225237 [details]
patch 2: added a comment.
Comment on attachment 225237 [details] patch 2: added a comment. Clearing flags on attachment: 225237 Committed r164717: <http://trac.webkit.org/changeset/164717> All reviewed patches have been landed. Closing bug. |