Bug 129356 – Forward application suspend resume notifications to the web process.

• Component: WebKit2
• Status: RESOLVED FIXED

[Jeremy Jones]

Forward application suspend resume notifications to the web process.

[Jeremy Jones]

Created attachment 225212 [details]
Patch

[Jeremy Jones]

These notifications are observed in MedisSessionManagerIOS.mm

[Simon Fraser (smfr)]

Comment on attachment 225212 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225212&action=review

I would like Gavin to look this over; we may want to propagate this info along with the other visibility-related data.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:72
> +SOFT_LINK_FRAMEWORK(UIKit)
> +SOFT_LINK_POINTER(UIKit, UIApplicationWillResignActiveNotification, NSString *)
> +SOFT_LINK_POINTER(UIKit, UIApplicationWillEnterForegroundNotification, NSString *)
> +
> +#define UIApplicationWillResignActiveNotification getUIApplicationWillResignActiveNotification()
> +#define UIApplicationWillEnterForegroundNotification getUIApplicationWillEnterForegroundNotification()

Why do these need to be soft-linked?

[Jeremy Jones]

Created attachment 225340 [details]
Patch

[Jeremy Jones]

This is just a rebase.

[Jeremy Jones]

(In reply to comment #3)
> (From update of attachment 225212 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=225212&action=review
> 
> I would like Gavin to look this over; we may want to propagate this info along with the other visibility-related data.
> 
> > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:72
> > +SOFT_LINK_FRAMEWORK(UIKit)
> > +SOFT_LINK_POINTER(UIKit, UIApplicationWillResignActiveNotification, NSString *)
> > +SOFT_LINK_POINTER(UIKit, UIApplicationWillEnterForegroundNotification, NSString *)
> > +
> > +#define UIApplicationWillResignActiveNotification getUIApplicationWillResignActiveNotification()
> > +#define UIApplicationWillEnterForegroundNotification getUIApplicationWillEnterForegroundNotification()
> 
> Why do these need to be soft-linked?

Oh right. It is just WebCore not WebProcess that doesn't link against UIKit.

Next patch will have this change.

[Jeremy Jones]

Created attachment 225341 [details]
Patch

[Jeremy Jones]

Also forward UIApplicationDidBecomeActiveNotification.

[Jeremy Jones]

Created attachment 225343 [details]
Patch

[Gavin Barraclough]

Comment on attachment 225343 [details]
Patch

Looks good to me.

[Eric Carlson]

This looks good to me as well, but I am not a WK2 owner so someone else will have to give it an r+.

[Jeremy Jones]

Created attachment 225530 [details]
Patch

[Jeremy Jones]

Removed #include <UIKit/UIKit.h> And instead have WebCore specific versions of the Notifications.

[WebKit Commit Bot]

Comment on attachment 225530 [details]
Patch

Rejecting attachment 225530 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 225530, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
urce/WebKit2/WebProcess/WebPage/WebPage.messages.in
Hunk #1 FAILED at 65.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/WebProcess/WebPage/WebPage.messages.in.rej
patching file Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm
Hunk #1 succeeded at 58 (offset 2 lines).
Hunk #2 succeeded at 1670 with fuzz 1 (offset 29 lines).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Sam Weinig']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/6551233372356608

[Jeremy Jones]

Created attachment 225688 [details]
Patch

[Jeremy Jones]

(In reply to comment #15)
> Created an attachment (id=225688) [details]
> Patch

Rebased patch.

[WebKit Commit Bot]

Comment on attachment 225688 [details]
Patch

Clearing flags on attachment: 225688

Committed r165028: <http://trac.webkit.org/changeset/165028>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Benjamin Poulain]

Comment on attachment 225688 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225688&action=review

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1686
> +void WebPage::applicationWillResignActive()
> +{
> +    [[NSNotificationCenter defaultCenter] postNotificationName:WebUIApplicationWillResignActiveNotification object:nil];
> +}
> +
> +void WebPage::applicationWillEnterForeground()
> +{
> +    [[NSNotificationCenter defaultCenter] postNotificationName:WebUIApplicationWillEnterForegroundNotification object:nil];
> +}
> +
> +void WebPage::applicationDidBecomeActive()
> +{
> +    [[NSNotificationCenter defaultCenter] postNotificationName:WebUIApplicationDidBecomeActiveNotification object:nil];
> +}

This is not okay.

Can you please add clean messaging from the WebKit layer to the WebCore layer?