Bug 129354

Summary: [iOS][WK2] Split the rects/scale updates in 3 internally consistent groups
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Benjamin Poulain
Reported 2014-02-25 18:16:29 PST
[iOS][WK2] Split the rects/scale updates in 3 internally consistent groups
Attachments
Patch (61.95 KB, patch)
2014-02-25 18:34 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (61.43 KB, patch)
2014-02-25 22:57 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (60.96 KB, patch)
2014-02-25 23:31 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-02-25 18:34:02 PST
Created attachment 225209 [details] Patch
Sam Weinig
Comment 2 2014-02-25 18:41:22 PST
Comment on attachment 225209 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225209&action=review > Source/WebKit2/UIProcess/ios/WKContentView.mm:153 > + if (!isStableState && abs(scale - _page->displayedContentScale()) < 0.0005) { Can we put 0.0005 into a constant with a good name? > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:362 > + // FIXME: patch separately. What does this mean?
Tim Horton
Comment 3 2014-02-25 18:52:11 PST
Comment on attachment 225209 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225209&action=review > Source/WebKit2/Scripts/webkit2/messages.py:224 > + 'VisibleContentRectUpdateInfo', weird that this doesn't have a namespace, isn't it?
Benjamin Poulain
Comment 4 2014-02-25 22:57:01 PST
Created attachment 225224 [details] Patch
Benjamin Poulain
Comment 5 2014-02-25 23:31:18 PST
Created attachment 225226 [details] Patch
Benjamin Poulain
Comment 6 2014-02-25 23:38:00 PST
Comment on attachment 225226 [details] Patch Clearing flags on attachment: 225226 Committed r164702: <http://trac.webkit.org/changeset/164702>
Benjamin Poulain
Comment 7 2014-02-25 23:38:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.