Bug 129341

Summary: JSDOMPromise methods should acquire VM lock before calling into JS
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ggaren, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 129265    
Attachments:
Description Flags
the patch. ggaren: review+

Mark Lam
Reported 2014-02-25 15:23:12 PST
Some crypto tests were failing after r164627: <http://trac.webkit.org/r164627> because the resolve() and reject() methods were calling into JS VM without using an entry shim. r164627 added assertions that caught this issue. Patch coming.
Attachments
the patch. (3.17 KB, patch)
2014-02-25 15:26 PST, Mark Lam 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2014-02-25 15:26:33 PST
Created attachment 225191 [details] the patch.
Geoffrey Garen
Comment 2 2014-02-25 15:43:29 PST
Comment on attachment 225191 [details] the patch. r=me
Mark Lam
Comment 3 2014-02-25 15:48:51 PST
Thanks. Landed in r164679: <http://trac.webkit.org/r164679>.
Darin Adler
Comment 4 2014-04-24 16:46:02 PDT
Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue.
Note You need to log in before you can comment on or make changes to this bug.