Bug 129299 – [New Multicolumn] -webkit-column-break-inside:avoid doesn't work

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Morten Stenshorne]

It works in the old/current multicol implementation.

[Morten Stenshorne]

Created attachment 225134 [details]
Test case

[Morten Stenshorne]

Bug in Blink: https://code.google.com/p/chromium/issues/detail?id=346661

[Morten Stenshorne]

Created attachment 225139 [details]
Patch

[Andrei Bucur]

Comment on attachment 225139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225139&action=review

r=me with some nits.

> Source/WebCore/ChangeLog:7
> +

Please add a short textual description of what the patch does.

> Source/WebCore/rendering/RenderBlockFlow.cpp:1696
> +    bool isInsideMulticolFlowThread = flowThread && !flowThread->isRenderNamedFlowThread();

In RenderLayer::updatePagination() the check for a multi-column flow thread is RenderObject::isInFlowRenderFlowThread(). I think it makes sense to use it here as well.

[Morten Stenshorne]

Comment on attachment 225139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225139&action=review

>> Source/WebCore/ChangeLog:7
>> +
> 
> Please add a short textual description of what the patch does.

Will do, once I know your opinion about the other issue raised.

>> Source/WebCore/rendering/RenderBlockFlow.cpp:1696
>> +    bool isInsideMulticolFlowThread = flowThread && !flowThread->isRenderNamedFlowThread();
> 
> In RenderLayer::updatePagination() the check for a multi-column flow thread is RenderObject::isInFlowRenderFlowThread(). I think it makes sense to use it here as well.

That should work as well. However, please take a look at RenderBlockFlow::applyAfterBreak() and RenderBlockFlow::applyBeforeBreak(), which checks for multi-column flow thread in the same way as I did here. I suggest that we keep it as it is. Or should I rather change applyAfterBreak() and applyBeforeBreak() as well.

[Andrei Bucur]

Comment on attachment 225139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225139&action=review

>>> Source/WebCore/rendering/RenderBlockFlow.cpp:1696
>>> +    bool isInsideMulticolFlowThread = flowThread && !flowThread->isRenderNamedFlowThread();
>> 
>> In RenderLayer::updatePagination() the check for a multi-column flow thread is RenderObject::isInFlowRenderFlowThread(). I think it makes sense to use it here as well.
> 
> That should work as well. However, please take a look at RenderBlockFlow::applyAfterBreak() and RenderBlockFlow::applyBeforeBreak(), which checks for multi-column flow thread in the same way as I did here. I suggest that we keep it as it is. Or should I rather change applyAfterBreak() and applyBeforeBreak() as well.

For this patch, I guess not. Keep it as it is then. I'll file a new bug to switch to isInFlow/isOutOfFlowRenderFlowThread getters where it makes sense.

[Morten Stenshorne]

Created attachment 225146 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 225146 [details]
Patch

Rejecting attachment 225146 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 225146 [details]
Patch

Clearing flags on attachment: 225146

Committed r164649: <http://trac.webkit.org/changeset/164649>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.