Summary: | Prune dead code for Web Inspector memory instrumentation. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
Component: | WebCore Misc. | Assignee: | Andreas Kling <kling> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | berto, bunhere, commit-queue, graouts, gyuyoung.kim, joepeck, kling, rakuco, sergio, timothy, zan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Andreas Kling
2014-02-24 20:10:35 PST
Created attachment 225117 [details]
Patch
Created attachment 225119 [details]
Patch
Comment on attachment 225119 [details] Patch Clearing flags on attachment: 225119 Committed r164637: <http://trac.webkit.org/changeset/164637> All reviewed patches have been landed. Closing bug. Comment on attachment 225119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225119&action=review > Source/WebCore/inspector/InspectorMemoryAgent.cpp:-82 > - *nodes = InspectorCounters::counterValue(InspectorCounters::NodeCounter); Are InspectorCounters used anywhere now? Can they be removed? > Source/WebCore/inspector/InspectorMemoryAgent.cpp:-83 > - *jsEventListeners = ThreadLocalInspectorCounters::current().counterValue(ThreadLocalInspectorCounters::JSEventListenerCounter); Same with ThreadLocalInspectorCounters. (In reply to comment #5) > (From update of attachment 225119 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=225119&action=review > > > Source/WebCore/inspector/InspectorMemoryAgent.cpp:-82 > > - *nodes = InspectorCounters::counterValue(InspectorCounters::NodeCounter); > > Are InspectorCounters used anywhere now? Can they be removed? They are still used to implement some window.internals testing API. It should be easy enough to replace it with something simpler. > > > Source/WebCore/inspector/InspectorMemoryAgent.cpp:-83 > > - *jsEventListeners = ThreadLocalInspectorCounters::current().counterValue(ThreadLocalInspectorCounters::JSEventListenerCounter); > > Same with ThreadLocalInspectorCounters. Hm. This one might come off right now! |