Bug 129286

Summary: Prune dead code for Web Inspector memory instrumentation.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bunhere, commit-queue, graouts, gyuyoung.kim, joepeck, kling, rakuco, sergio, timothy, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andreas Kling
Reported 2014-02-24 20:10:35 PST
Prune dead code for Web Inspector memory instrumentation.
Attachments
Patch (23.16 KB, patch)
2014-02-24 20:11 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (27.59 KB, patch)
2014-02-24 20:48 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-02-24 20:11:54 PST
Created attachment 225117 [details] Patch
Andreas Kling
Comment 2 2014-02-24 20:48:40 PST
Created attachment 225119 [details] Patch
WebKit Commit Bot
Comment 3 2014-02-25 00:13:59 PST
Comment on attachment 225119 [details] Patch Clearing flags on attachment: 225119 Committed r164637: <http://trac.webkit.org/changeset/164637>
WebKit Commit Bot
Comment 4 2014-02-25 00:14:03 PST
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 5 2014-02-25 10:41:25 PST
Comment on attachment 225119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225119&action=review > Source/WebCore/inspector/InspectorMemoryAgent.cpp:-82 > - *nodes = InspectorCounters::counterValue(InspectorCounters::NodeCounter); Are InspectorCounters used anywhere now? Can they be removed? > Source/WebCore/inspector/InspectorMemoryAgent.cpp:-83 > - *jsEventListeners = ThreadLocalInspectorCounters::current().counterValue(ThreadLocalInspectorCounters::JSEventListenerCounter); Same with ThreadLocalInspectorCounters.
Andreas Kling
Comment 6 2014-02-25 10:54:06 PST
(In reply to comment #5) > (From update of attachment 225119 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=225119&action=review > > > Source/WebCore/inspector/InspectorMemoryAgent.cpp:-82 > > - *nodes = InspectorCounters::counterValue(InspectorCounters::NodeCounter); > > Are InspectorCounters used anywhere now? Can they be removed? They are still used to implement some window.internals testing API. It should be easy enough to replace it with something simpler. > > > Source/WebCore/inspector/InspectorMemoryAgent.cpp:-83 > > - *jsEventListeners = ThreadLocalInspectorCounters::current().counterValue(ThreadLocalInspectorCounters::JSEventListenerCounter); > > Same with ThreadLocalInspectorCounters. Hm. This one might come off right now!
Note You need to log in before you can comment on or make changes to this bug.