| Summary: | Break out ImageControls style into an external stylesheet | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
| Component: | Images | Assignee: | Brady Eidson <beidson> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Brady Eidson
2014-02-24 13:41:29 PST
Created attachment 225093 [details]
Patch v1
Comment on attachment 225093 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=225093&action=review r=me with nit. > Source/WebCore/html/shadow/mac/ImageControlsRootElementMac.cpp:33 > +#include "Event.h" > +#include "EventNames.h" > +#include "Page.h" Are these really necessary? (In reply to comment #2) > (From update of attachment 225093 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=225093&action=review > > r=me with nit. > > > Source/WebCore/html/shadow/mac/ImageControlsRootElementMac.cpp:33 > > +#include "Event.h" > > +#include "EventNames.h" > > +#include "Page.h" > > Are these really necessary? Nope, sorry - leftovers from a patch split-up |