Bug 129245

Summary: [GTK] Remove unneeded method webkitWebViewBaseRequestExitFullScreen
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, commit-queue, gustavo, mrobinson, svillar
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch svillar: review+

Carlos Garcia Campos
Reported 2014-02-24 00:58:54 PST
It's a semi-private method but that it's only used once in WebKitWebViewBase.cpp and it contains a single line.
Attachments
Patch (2.87 KB, patch)
2014-02-24 01:01 PST, Carlos Garcia Campos 		svillar: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-02-24 01:01:13 PST
Created attachment 225032 [details] Patch
WebKit Commit Bot
Comment 2 2014-02-24 01:02:45 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Sergio Villar Senin
Comment 3 2014-02-24 01:13:10 PST
Comment on attachment 225032 [details] Patch Let's do it. BTW what about also replacing the switch by an if statement in webkitWebViewBaseKeyPressEvent? Looks like abusing the syntax to me.
Carlos Garcia Campos
Comment 4 2014-02-24 01:26:03 PST
Committed r164578: <http://trac.webkit.org/changeset/164578>
Note You need to log in before you can comment on or make changes to this bug.