Summary: | AX: AccessibilityObject::findMatchingObjects should never include 'this' in results. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Samuel White <samuel_white> | ||||||||
Component: | Accessibility | Assignee: | Samuel White <samuel_white> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, rniwa, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Mac (Intel) | ||||||||||
OS: | OS X 10.9 | ||||||||||
Attachments: |
|
Description
Samuel White
2014-02-24 00:16:26 PST
Created attachment 225083 [details]
Patch.
Previously, the container object could be included in the search results when searching backwards. This patch removes that and makes forward/backwards results consistent with each other.
Comment on attachment 225083 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=225083&action=review > LayoutTests/platform/mac/accessibility/search-predicate-container-not-included.html:25 > + shouldBe("forwardResult", "undefined"); Make sure this works on wk2 as well as wk1 (In reply to comment #4) > (From update of attachment 225083 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=225083&action=review > > > LayoutTests/platform/mac/accessibility/search-predicate-container-not-included.html:25 > > + shouldBe("forwardResult", "undefined"); > > Make sure this works on wk2 as well as wk1 Looks like it doesn't, fixing now. Comment on attachment 225083 [details] Patch. Attachment 225083 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5780764994043904 New failing tests: svg/masking/mask-negative-scale.svg platform/mac/accessibility/search-predicate-container-not-included.html Created attachment 225091 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 225092 [details]
Updated patch.
Updated test to check the result count instead of the result type to make the test more test harness agnostic.
Comment on attachment 225092 [details] Updated patch. Clearing flags on attachment: 225092 Committed r164616: <http://trac.webkit.org/changeset/164616> All reviewed patches have been landed. Closing bug. |