Summary: | CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify contains seemingly accidental unreachable code | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | WebCore Misc. | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, commit-queue, joepeck, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2014-02-21 20:39:19 PST
Created attachment 224943 [details]
proposed fix
Comment on attachment 224943 [details]
proposed fix
r=me!
Should we write a test?
Comment on attachment 224943 [details] proposed fix > Should we write a test? I don't think that there is any way to get to the failureCallback() branch in practice. Comment on attachment 224943 [details] proposed fix Clearing flags on attachment: 224943 Committed r164528: <http://trac.webkit.org/changeset/164528> All reviewed patches have been landed. Closing bug. |