Bug 129185

Summary:

Web Inspector: Remove WebInspector.EventHandler in favor of WebInspector.EventListenerSet

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Description Timothy Hatcher 2014-02-21 17:03:46 PST

We have two similar classes, WebInspector.EventHandler and WebInspector.EventListenerSet. We should just remove the one client of WebInspector.EventHandler and replace it with WebInspector.EventListenerSet or vanilla listeners.

Comment 1 Radar WebKit Bug Importer 2014-02-21 17:04:25 PST

<rdar://problem/16140196>

Comment 2 Diego Pino 2014-03-03 15:38:06 PST

Created attachment 225701 [details]
Patch

Comment 3 Timothy Hatcher 2014-03-03 15:39:55 PST

Comment on attachment 225701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225701&action=review

> Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:1258
> +            this._popoverEventHandler = new WebInspector.EventListenerSet(this, "Popover listeners");

This should be called _popoverEventListeners or _popoverEventListenerSet to match the class name better.

Comment 4 Diego Pino 2014-03-03 22:58:48 PST

Created attachment 225743 [details]
Patch

Comment 5 WebKit Commit Bot 2014-03-04 08:26:39 PST

Comment on attachment 225743 [details]
Patch

Clearing flags on attachment: 225743

Committed r165052: <http://trac.webkit.org/changeset/165052>

Comment 6 WebKit Commit Bot 2014-03-04 08:26:41 PST

All reviewed patches have been landed.  Closing bug.