Bug 129185

Summary: Web Inspector: Remove WebInspector.EventHandler in favor of WebInspector.EventListenerSet
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Timothy Hatcher
Reported 2014-02-21 17:03:46 PST
We have two similar classes, WebInspector.EventHandler and WebInspector.EventListenerSet. We should just remove the one client of WebInspector.EventHandler and replace it with WebInspector.EventListenerSet or vanilla listeners.
Attachments
Patch (6.09 KB, patch)
2014-03-03 15:38 PST, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (6.14 KB, patch)
2014-03-03 22:58 PST, Diego Pino 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-02-21 17:04:25 PST
<rdar://problem/16140196>
Diego Pino
Comment 2 2014-03-03 15:38:06 PST
Created attachment 225701 [details] Patch
Timothy Hatcher
Comment 3 2014-03-03 15:39:55 PST
Comment on attachment 225701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225701&action=review > Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:1258 > + this._popoverEventHandler = new WebInspector.EventListenerSet(this, "Popover listeners"); This should be called _popoverEventListeners or _popoverEventListenerSet to match the class name better.
Diego Pino
Comment 4 2014-03-03 22:58:48 PST
Created attachment 225743 [details] Patch
WebKit Commit Bot
Comment 5 2014-03-04 08:26:39 PST
Comment on attachment 225743 [details] Patch Clearing flags on attachment: 225743 Committed r165052: <http://trac.webkit.org/changeset/165052>
WebKit Commit Bot
Comment 6 2014-03-04 08:26:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.