Bug 129177

Summary:

Replace svg/clip-path pixel tests by reference tests

Product:

WebKit

Reporter:

Dirk Schulze <krit>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, cdumez, commit-queue, dino, gyuyoung.kim, kling, koivisto, sergio, simon.fraser, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch - removes all pixel tests and pixel results	rniwa: review+
New reference tests	none
New reference tests	none
New reference tests	dino: review+
Upload new tests	none
Remove pixel tests	commit-queue: commit-queue-

Dirk Schulze

Reported 2014-02-21 15:38:00 PST

We got some regressions on SVG clip-path tests. To detect regressions earlier I will replace all clip-path pixel tests with ref tests.

Attachments
Patch - removes all pixel tests and pixel results (995.65 KB, patch) 2014-02-21 15:41 PST, Dirk Schulze	rniwa: review+	Details Formatted Diff Diff
New reference tests (91.23 KB, patch) 2014-02-21 15:54 PST, Dirk Schulze	no flags	Details Formatted Diff Diff
New reference tests (82.04 KB, patch) 2014-02-21 16:00 PST, Dirk Schulze	no flags	Details Formatted Diff Diff
New reference tests (91.25 KB, patch) 2014-02-21 16:10 PST, Dirk Schulze	dino: review+	Details Formatted Diff Diff
Upload new tests (91.26 KB, patch) 2014-02-21 22:34 PST, Dirk Schulze	no flags	Details Formatted Diff Diff
Remove pixel tests (995.66 KB, patch) 2014-02-21 23:43 PST, Dirk Schulze	commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Dirk Schulze

Comment 1 2014-02-21 15:41:01 PST

Created attachment 224917 [details] Patch - removes all pixel tests and pixel results

Dirk Schulze

Comment 2 2014-02-21 15:54:56 PST

Created attachment 224919 [details] New reference tests

Dirk Schulze

Comment 3 2014-02-21 16:00:18 PST

Created attachment 224920 [details] New reference tests Without change log. Will add change log on landing.

Dirk Schulze

Comment 4 2014-02-21 16:10:33 PST

Created attachment 224924 [details] New reference tests

WebKit Commit Bot

Comment 5 2014-02-21 16:13:55 PST

Attachment 224924 [details] did not pass style-queue: ERROR: LayoutTests/platform/mac/TestExpectations:1339: Line contains tab character. [whitespace/tab] [5] ERROR: LayoutTests/platform/gtk/TestExpectations:1552: Line contains tab character. [whitespace/tab] [5] ERROR: LayoutTests/platform/win/TestExpectations:2808: Line contains tab character. [whitespace/tab] [5] ERROR: LayoutTests/platform/efl/TestExpectations:1871: Line contains tab character. [whitespace/tab] [5] Total errors found: 4 in 133 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dean Jackson

Comment 6 2014-02-21 18:22:25 PST

Comment on attachment 224924 [details] New reference tests r+ from me once you fix style errors.

Dirk Schulze

Comment 7 2014-02-21 22:34:41 PST

Created attachment 224947 [details] Upload new tests Upload new tests. Remove pixel tests in 2nd step.

Ryosuke Niwa

Comment 8 2014-02-21 22:42:48 PST

Comment on attachment 224917 [details] Patch - removes all pixel tests and pixel results rs=me

WebKit Commit Bot

Comment 9 2014-02-21 23:14:56 PST

Comment on attachment 224947 [details] Upload new tests Clearing flags on attachment: 224947 Committed r164531: <http://trac.webkit.org/changeset/164531>

Dirk Schulze

Comment 10 2014-02-21 23:43:36 PST

Created attachment 224951 [details] Remove pixel tests Remove pixel tests

WebKit Commit Bot

Comment 11 2014-02-21 23:46:28 PST

Comment on attachment 224951 [details] Remove pixel tests Rejecting attachment 224951 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 224951, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ask-path-and-image-based-clipping.svg' patching file LayoutTests/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt rm 'LayoutTests/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt' patching file LayoutTests/svg/clip-path/nested-clip-in-mask-path-based-clipping.svg rm 'LayoutTests/svg/clip-path/nested-clip-in-mask-path-based-clipping.svg' Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/4622606527365120

Dirk Schulze

Comment 12 2014-02-22 05:53:36 PST

Committed r164539: <http://trac.webkit.org/changeset/164539>

Note You need to log in before you can comment on or make changes to this bug.