Bug 129168

Summary: Web Inspector: remove old inspector tests that cannot be ported
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Tools / TestsAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, jer.noble, joepeck, philipj, sergio, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch timothy: review+, commit-queue: commit-queue-

Blaze Burg
Reported 2014-02-21 13:56:20 PST
411 is a lot of skipped tests. I think maybe 100 at most (say, debugger tests) should be kept and evaluated more carefully. There are a lot of UI specific tests.
Attachments
patch (1.17 MB, patch)
2014-02-21 14:34 PST, Blaze Burg 		timothy: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2014-02-21 14:34:36 PST
Created attachment 224910 [details] patch
Timothy Hatcher
Comment 2 2014-02-21 15:05:24 PST
Comment on attachment 224910 [details] patch rs=me!
WebKit Commit Bot
Comment 3 2014-02-21 16:08:14 PST
Comment on attachment 224910 [details] patch Rejecting attachment 224910 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 224910, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 164509 = 7af1393f6a635141131eadb1d8d4349b75de253c r164510 = eafb76a13ed3e62e4a85ec458823a344a7b6c25a r164511 = f9e0215cbe9864209a3399d88ad0f2053be4fb3e Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/5544649972252672
Blaze Burg
Comment 4 2014-02-21 16:23:41 PST
Committed r164515: <http://trac.webkit.org/changeset/164515>
Note You need to log in before you can comment on or make changes to this bug.