Bug 129166

Summary: [EME] Add a CDMSession for MediaPlayerPrivateMediaSourceAVFObjC
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
eric.carlson: review+
Patch for landing
none
Patch for landing
none
Patch for landing none

Description Jer Noble 2014-02-21 13:32:32 PST 
[EME] Add a CDMSession for MediaPlayerPrivateMediaSourceAVFObjC
Comment 1 Jer Noble 2014-02-21 13:54:22 PST 
Created attachment 224901 [details]
Patch
Comment 2 Jer Noble 2014-02-21 16:23:46 PST 
Created attachment 224925 [details]
Patch

Rebaselined
Comment 3 Eric Carlson 2014-02-21 16:51:12 PST 
Comment on attachment 224925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224925&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:67
> +    UNUSED_PARAM(errorCode);
> +    UNUSED_PARAM(systemCode);

Maybe you should set these out params to 0?

> Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:110
> +    LOG(Media, "CDMSessionMediaSourceAVFObjC::update(%p) - key data", this);
> +    RetainPtr<NSData> keyData = adoptNS([[NSData alloc] initWithBytes:key->data() length:key->length()]);
> +    [m_parent->parser() processContentKeyResponseData:keyData.get() forTrackID:m_parent->protectedTrackID()];
> +    return true;

Ditto about errorCode and systemCode.
Comment 4 Jer Noble 2014-02-21 20:19:02 PST 
Created attachment 224942 [details]
Patch for landing
Comment 5 Jer Noble 2014-02-21 21:03:03 PST 
Created attachment 224944 [details]
Patch for landing
Comment 6 Jer Noble 2014-02-21 21:34:07 PST 
Created attachment 224945 [details]
Patch for landing
Comment 7 Jer Noble 2014-02-21 22:12:57 PST 
Committed r164529: <http://trac.webkit.org/changeset/164529>