Bug 129166

Summary: [EME] Add a CDMSession for MediaPlayerPrivateMediaSourceAVFObjC
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
eric.carlson: review+
Patch for landing
none
Patch for landing
none
Patch for landing none

Jer Noble
Reported 2014-02-21 13:32:32 PST
[EME] Add a CDMSession for MediaPlayerPrivateMediaSourceAVFObjC
Attachments
Patch (27.90 KB, patch)
2014-02-21 13:54 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (27.81 KB, patch)
2014-02-21 16:23 PST, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (28.02 KB, patch)
2014-02-21 20:19 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (28.06 KB, patch)
2014-02-21 21:03 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (28.12 KB, patch)
2014-02-21 21:34 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-02-21 13:54:22 PST
Created attachment 224901 [details] Patch
Jer Noble
Comment 2 2014-02-21 16:23:46 PST
Created attachment 224925 [details] Patch Rebaselined
Eric Carlson
Comment 3 2014-02-21 16:51:12 PST
Comment on attachment 224925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224925&action=review > Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:67 > + UNUSED_PARAM(errorCode); > + UNUSED_PARAM(systemCode); Maybe you should set these out params to 0? > Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:110 > + LOG(Media, "CDMSessionMediaSourceAVFObjC::update(%p) - key data", this); > + RetainPtr<NSData> keyData = adoptNS([[NSData alloc] initWithBytes:key->data() length:key->length()]); > + [m_parent->parser() processContentKeyResponseData:keyData.get() forTrackID:m_parent->protectedTrackID()]; > + return true; Ditto about errorCode and systemCode.
Jer Noble
Comment 4 2014-02-21 20:19:02 PST
Created attachment 224942 [details] Patch for landing
Jer Noble
Comment 5 2014-02-21 21:03:03 PST
Created attachment 224944 [details] Patch for landing
Jer Noble
Comment 6 2014-02-21 21:34:07 PST
Created attachment 224945 [details] Patch for landing
Jer Noble
Comment 7 2014-02-21 22:12:57 PST
Committed r164529: <http://trac.webkit.org/changeset/164529>
Note You need to log in before you can comment on or make changes to this bug.