Bug 129135

Summary:

ASSERT on touches callbacks after r164409 on iOS

Product:

WebKit

Reporter:

Enrica Casucci <enrica>

Component:

WebKit2

Assignee:

Enrica Casucci <enrica>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, ap

Priority:

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=173745

Attachments:

Description	Flags
Patch	ap: review+

Enrica Casucci

Reported 2014-02-20 17:55:35 PST

http://trac.webkit.org/changeset/164409 caused a number of ASSERT to fire on iOS. true was used in the call to m_performCallbackWithReturnValue (instead of false) and false in invalidate (instead of true). This change also reintroduced the use of isMainThread on WebKit2 which doesn't work on iOS and should replaced with RunLoop::isMain().

Attachments
Patch (2.84 KB, patch) 2014-02-20 17:58 PST, Enrica Casucci	ap: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Enrica Casucci

Comment 1 2014-02-20 17:58:28 PST

Created attachment 224814 [details] Patch

Enrica Casucci

Comment 2 2014-02-20 18:08:55 PST

Committed revision 164462.

Note You need to log in before you can comment on or make changes to this bug.