Bug 129131

Summary:

DefaultGCActivityCallback::doWork() should reschedule if GC is deferred

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fpizlo, ggaren, mhahnenberg, mmirman, msaboff, oliver

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
the patch	mhahnenberg: review+

Description Mark Lam 2014-02-20 17:17:22 PST

Currently, DefaultGCActivityCallback::doWork() does not check if the GC needs to be deferred before commencing.  Will fix.

ref: <rdar://problem/15447622>

Comment 1 Mark Lam 2014-02-20 18:02:24 PST

Created attachment 224815 [details]
the patch

Comment 2 Mark Hahnenberg 2014-02-20 18:04:43 PST

Comment on attachment 224815 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224815&action=review

r=me

> Source/JavaScriptCore/ChangeLog:12
> +        supposed to be deferred and re-schedule if needed. It only commences with

reschedules

Comment 3 Mark Lam 2014-02-20 18:48:37 PST

Thanks.  Landed in r164463: <http://trac.webkit.org/r164463>.