Bug 129126

Summary: Move the image controls setting to Settings.in
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1
thorton: review+, beidson: commit-queue-
Patch for landing. none

Description Brady Eidson 2014-02-20 15:56:08 PST 
Move the image controls setting to Settings.in
Comment 1 Brady Eidson 2014-02-20 15:57:21 PST 
Created attachment 224807 [details]
Patch v1
Comment 2 Tim Horton 2014-02-20 16:08:33 PST 
Comment on attachment 224807 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=224807&action=review

> Source/WebCore/page/Settings.h:-242
> -    bool imageControlsEnabled() { return m_imageControlsEnabled; }

do you still need the member and its initializer? I don't see them for other Settings.in settings...
Comment 3 Brady Eidson 2014-02-20 16:32:50 PST 
Created attachment 224808 [details]
Patch for landing.
Comment 4 WebKit Commit Bot 2014-02-20 17:09:17 PST 
Comment on attachment 224808 [details]
Patch for landing.

Clearing flags on attachment: 224808

Committed r164458: <http://trac.webkit.org/changeset/164458>
Comment 5 WebKit Commit Bot 2014-02-20 17:09:19 PST 
All reviewed patches have been landed.  Closing bug.