Bug 12912

Summary: Variable scoping rules incorrectly evaluated
Product: WebKit Reporter: Dan Waylonis <waylonis>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Critical CC: ap, zwarich
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
HTML page that illustrates the evaluation failure. none

Dan Waylonis
Reported 2007-02-27 11:34:36 PST
On both Safari 10.4.8 and TOT WebKit, the JavaScript code is incorrectly evaluated.
Attachments
HTML page that illustrates the evaluation failure. (1.87 KB, text/html)
2007-02-27 11:35 PST, Dan Waylonis 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Dan Waylonis
Comment 1 2007-02-27 11:35:48 PST
Created attachment 13405 [details] HTML page that illustrates the evaluation failure.
Alexey Proskuryakov
Comment 2 2007-02-27 22:26:33 PST
See also: bug 7751, bug 11399 (duplicates?)
Cameron Zwarich (cpst)
Comment 3 2007-07-10 17:19:22 PDT
This bug seems to be fixed in TOT, as the test case runs correctly.
David Kilzer (:ddkilzer)
Comment 4 2007-07-10 22:27:42 PDT
(In reply to comment #3) > This bug seems to be fixed in TOT, as the test case runs correctly. (In reply to comment #2) > See also: bug 7751, bug 11399 (duplicates?) Attachment 13405 [details] runs correctly with a local debug build of WebKit r24147 with Safari 3.0 (522.12) on Mac OS X 10.4.10 (8R218). However, the tests for Bug 7751 and Bug 11399 are still broken.
Alexey Proskuryakov
Comment 5 2007-07-11 05:07:58 PDT
That's interesting! I think we need to research when this was fixed and whether a test case was landed with the fix.
Cameron Zwarich (cpst)
Comment 6 2007-07-11 13:32:52 PDT
The bug is still in the r21388 nightly, but is fixed by the r21420 nightly. The revision that fixes it is 21409, which only changes one source code file, nodes2string.cpp. The specific change that fixes the bug is the first in the diff <http://trac.webkit.org/projects/webkit/changeset/21409>. Since the patch is so small and specific, I think the regression tests from that revision adequately cover this bug. Bug 7751 is probably not a bug, as I noted there, and bug 11399, according to Geoff Garen's comment, is due to a choice (deliberate or not) regarding the behaviour of inner windows.
Alexey Proskuryakov
Comment 7 2007-07-11 21:22:24 PDT
Marking as fixed per the above comment.
Note You need to log in before you can comment on or make changes to this bug.