Summary: | Get rid of the unused 'immediate' parameters from repaint related functions | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Renata Hodovan <rhodovan.u-szeged> | ||||||||
Component: | Layout and Rendering | Assignee: | Renata Hodovan <rhodovan.u-szeged> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bunhere, cdumez, cmarcelo, commit-queue, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, japhet, kangil.han, kondapallykalyan, pdr, schenney, sergio, simon.fraser, WebkitBugTracker | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Renata Hodovan
2014-02-20 10:54:29 PST
Created attachment 224775 [details]
Proposed patch
Comment on attachment 224775 [details]
Proposed patch
Nice.
Created attachment 224803 [details]
Proposed patch
@simon.fraser: thank you for the review. Unfortunately, the mac and wk2 builds failed after you set the r+ flag. To make sure I don't mess up the build of any ports, I upload an updated patch again.
In the update, there were two 'non-trivial' modifications. WebChromeClient::invalidateRootView() does depend on the immediate argument and ScrollView::scrollContents() calls it both ways. The other case is WebChromeClient::invalidateRootView() which is almost always called with immediate set to false, but ScrollView::paintOverhangAreas() and ScrollView::removePanScrollIcon() call it with true. In this patch I considered it as false and eliminated the related code. However, I'm not familiar with these ports, so I'd like to ask for a second round of review. :)
Created attachment 225064 [details]
Proposed patch
Updating WebCore.exp.in to fix the mac builds.
Comment on attachment 225064 [details] Proposed patch Clearing flags on attachment: 225064 Committed r164594: <http://trac.webkit.org/changeset/164594> All reviewed patches have been landed. Closing bug. |