Bug 129111

Summary: Get rid of the unused 'immediate' parameters from repaint related functions
Product: WebKit Reporter: Renata Hodovan <rhodovan.u-szeged>
Component: Layout and RenderingAssignee: Renata Hodovan <rhodovan.u-szeged>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, cmarcelo, commit-queue, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, japhet, kangil.han, kondapallykalyan, pdr, schenney, sergio, simon.fraser, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
simon.fraser: review+
Proposed patch
none
Proposed patch none

Renata Hodovan
Reported 2014-02-20 10:54:29 PST
The 'immediate' parameter is needlessly passed around, so it should be removed (as the fixme says it in WebCore::RenderView::repaintViewRectangle).
Attachments
Proposed patch (54.36 KB, patch)
2014-02-20 11:17 PST, Renata Hodovan 		simon.fraser: review+
DetailsFormatted DiffDiff
Proposed patch (60.90 KB, patch)
2014-02-20 15:36 PST, Renata Hodovan 		no flags
DetailsFormatted DiffDiff
Proposed patch (61.67 KB, patch)
2014-02-24 07:05 PST, Renata Hodovan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Renata Hodovan
Comment 1 2014-02-20 11:17:17 PST
Created attachment 224775 [details] Proposed patch
Simon Fraser (smfr)
Comment 2 2014-02-20 11:28:50 PST
Comment on attachment 224775 [details] Proposed patch Nice.
Renata Hodovan
Comment 3 2014-02-20 15:36:46 PST
Created attachment 224803 [details] Proposed patch @simon.fraser: thank you for the review. Unfortunately, the mac and wk2 builds failed after you set the r+ flag. To make sure I don't mess up the build of any ports, I upload an updated patch again. In the update, there were two 'non-trivial' modifications. WebChromeClient::invalidateRootView() does depend on the immediate argument and ScrollView::scrollContents() calls it both ways. The other case is WebChromeClient::invalidateRootView() which is almost always called with immediate set to false, but ScrollView::paintOverhangAreas() and ScrollView::removePanScrollIcon() call it with true. In this patch I considered it as false and eliminated the related code. However, I'm not familiar with these ports, so I'd like to ask for a second round of review. :)
Renata Hodovan
Comment 4 2014-02-24 07:05:05 PST
Created attachment 225064 [details] Proposed patch Updating WebCore.exp.in to fix the mac builds.
WebKit Commit Bot
Comment 5 2014-02-24 10:59:56 PST
Comment on attachment 225064 [details] Proposed patch Clearing flags on attachment: 225064 Committed r164594: <http://trac.webkit.org/changeset/164594>
WebKit Commit Bot
Comment 6 2014-02-24 10:59:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.