Bug 129105

Summary: Modernize JSGlobalLock and JSLockHolder
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: mark.lam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 146448    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch msaboff: review+

Anders Carlsson
Reported 2014-02-20 09:06:04 PST
Modernize JSGlobalLock and JSLockHolder
Attachments
Patch (4.25 KB, patch)
2014-02-20 09:09 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (4.27 KB, patch)
2014-02-20 09:37 PST, Anders Carlsson 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-02-20 09:09:03 PST
Created attachment 224760 [details] Patch
Anders Carlsson
Comment 2 2014-02-20 09:37:13 PST
Created attachment 224763 [details] Patch
Michael Saboff
Comment 3 2014-02-20 09:39:55 PST
Comment on attachment 224763 [details] Patch r=me
Anders Carlsson
Comment 4 2014-02-21 08:39:48 PST
Committed r164484: <http://trac.webkit.org/changeset/164484>
Mark Lam
Comment 5 2015-07-16 08:56:01 PDT
Looks like use of std::thread::id() has performance implications on Windows. See https://bugs.webkit.org/show_bug.cgi?id=146448.
Anders Carlsson
Comment 6 2015-07-16 10:27:27 PDT
(In reply to comment #5) > Looks like use of std::thread::id() has performance implications on Windows. > See https://bugs.webkit.org/show_bug.cgi?id=146448. I don't think that should affect our decisions - the Windows port is pretty much in maintenance mode only.
Note You need to log in before you can comment on or make changes to this bug.