Bug 129105

Summary:

Modernize JSGlobalLock and JSLockHolder

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mark.lam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

146448

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	msaboff: review+

Description Anders Carlsson 2014-02-20 09:06:04 PST

Modernize JSGlobalLock and JSLockHolder

Comment 1 Anders Carlsson 2014-02-20 09:09:03 PST

Created attachment 224760 [details]
Patch

Comment 2 Anders Carlsson 2014-02-20 09:37:13 PST

Created attachment 224763 [details]
Patch

Comment 3 Michael Saboff 2014-02-20 09:39:55 PST

Comment on attachment 224763 [details]
Patch

r=me

Comment 4 Anders Carlsson 2014-02-21 08:39:48 PST

Committed r164484: <http://trac.webkit.org/changeset/164484>

Comment 5 Mark Lam 2015-07-16 08:56:01 PDT

Looks like use of std::thread::id() has performance implications on Windows.  See https://bugs.webkit.org/show_bug.cgi?id=146448.

Comment 6 Anders Carlsson 2015-07-16 10:27:27 PDT

(In reply to comment #5)
> Looks like use of std::thread::id() has performance implications on Windows.
> See https://bugs.webkit.org/show_bug.cgi?id=146448.

I don't think that should affect our decisions - the Windows port is pretty much in maintenance mode only.