Bug 129095

Summary: Web Inspector: allow drag-to-adjust on angle input of gradients editor
Product: WebKit Reporter: Antoine Quint <graouts>
Component: Web InspectorAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 119686    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Antoine Quint
Reported 2014-02-20 04:11:06 PST
The patch for https://bugs.webkit.org/show_bug.cgi?id=119686 will provide a new gradients editor but its angle input doesn't support drag-to-adjust the way numbers in CodeMirror editors allow. This would be a great way to adjust the angle, so we should support a similar system. This will likely mean that we'd have to generalize CodeMirrorDragToAlterNumberController to work with CodeMirror editors as well as other types of text values, probably with a simple delegate system.
Attachments
Patch (34.30 KB, patch)
2014-02-21 05:41 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-02-20 04:11:32 PST
<rdar://problem/16120195>
Radar WebKit Bug Importer
Comment 2 2014-02-20 04:11:33 PST
<rdar://problem/16120196>
Antoine Quint
Comment 3 2014-02-21 05:41:56 PST
Created attachment 224856 [details] Patch
WebKit Commit Bot
Comment 4 2014-02-22 07:23:52 PST
Comment on attachment 224856 [details] Patch Clearing flags on attachment: 224856 Committed r164540: <http://trac.webkit.org/changeset/164540>
WebKit Commit Bot
Comment 5 2014-02-22 07:23:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.