Bug 129088

Summary: Web Inspector: Popover should animate its frame to display its refreshed content
Product: WebKit Reporter: Antoine Quint <graouts>
Component: Web InspectorAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 119686    
Attachments:
Description Flags
Patch none

Antoine Quint
Reported 2014-02-20 01:33:18 PST
The Popover.prototype.update() method allows for a popover to recompute and redraw its frame to accommodate a change within the DOM node set as its .content, but that update is discrete. In many situations, the edge the popover attaches to the target frame is unchanged and thus it should be possible to animate the popover frame for a more pleasing transition of content.
Attachments
Patch (16.13 KB, patch)
2014-02-20 01:55 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-02-20 01:33:34 PST
<rdar://problem/16119649>
Antoine Quint
Comment 2 2014-02-20 01:35:37 PST
Necessary to land https://bugs.webkit.org/show_bug.cgi?id=119686.
Antoine Quint
Comment 3 2014-02-20 01:55:29 PST
Created attachment 224733 [details] Patch
WebKit Commit Bot
Comment 4 2014-02-20 09:21:59 PST
Comment on attachment 224733 [details] Patch Clearing flags on attachment: 224733 Committed r164432: <http://trac.webkit.org/changeset/164432>
WebKit Commit Bot
Comment 5 2014-02-20 09:22:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.