Bug 129088

Summary:

Web Inspector: Popover should animate its frame to display its refreshed content

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Web Inspector

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

119686

Attachments:

Description	Flags
Patch	none

Description Antoine Quint 2014-02-20 01:33:18 PST

The Popover.prototype.update() method allows for a popover to recompute and redraw its frame to accommodate a change within the DOM node set as its .content, but that update is discrete. In many situations, the edge the popover attaches to the target frame is unchanged and thus it should be possible to animate the popover frame for a more pleasing transition of content.

Comment 1 Radar WebKit Bug Importer 2014-02-20 01:33:34 PST

<rdar://problem/16119649>

Comment 2 Antoine Quint 2014-02-20 01:35:37 PST

Necessary to land https://bugs.webkit.org/show_bug.cgi?id=119686.

Comment 3 Antoine Quint 2014-02-20 01:55:29 PST

Created attachment 224733 [details]
Patch

Comment 4 WebKit Commit Bot 2014-02-20 09:21:59 PST

Comment on attachment 224733 [details]
Patch

Clearing flags on attachment: 224733

Committed r164432: <http://trac.webkit.org/changeset/164432>

Comment 5 WebKit Commit Bot 2014-02-20 09:22:01 PST

All reviewed patches have been landed.  Closing bug.