Summary: | ASSERT in FrameLoader::shouldInterruptLoadForXFrameOptions | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pratik Solanki <psolanki> | ||||
Component: | WebCore Misc. | Assignee: | Pratik Solanki <psolanki> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, beidson, commit-queue, eric.carlson, japhet, psolanki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Pratik Solanki
2014-02-19 21:36:58 PST
Created attachment 224705 [details]
Patch
Comment on attachment 224705 [details]
Patch
This breaks gcc build. I think that we need an ASSERT_NOT_REACHED() and return at the end.
/mnt/eflews/webkit/WebKit/Source/WebCore/loader/FrameLoader.cpp: In member function 'bool WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions(const WTF::String&, const WebCore::URL&, long unsigned int)':
/mnt/eflews/webkit/WebKit/Source/WebCore/loader/FrameLoader.cpp:3074:1: error: control reaches end of non-void function [-Werror=return-type]
cc1plus: all warnings being treated as errors
(In reply to comment #3) > (From update of attachment 224705 [details]) > This breaks gcc build. I think that we need an ASSERT_NOT_REACHED() and return at the end. Ok. Will add that and land the patch. Thanks for the review. Committed r164435: <http://trac.webkit.org/changeset/164435> |