| Summary: | [CSS Shapes] inset and inset-rectangle trigger assert with replaced element and large percentage dimension | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Bem Jones-Bey <bjonesbe> | ||||||||
| Component: | New Bugs | Assignee: | Bem Jones-Bey <bjonesbe> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Bem Jones-Bey
2014-02-19 14:02:16 PST
Created attachment 224674 [details]
Patch
Created attachment 224679 [details]
Patch
smfr, would you review? Comment on attachment 224679 [details]
Patch
I thought you were going to change the tests to use <img>?
(In reply to comment #4) > (From update of attachment 224679 [details]) > I thought you were going to change the tests to use <img>? I didn't because that requires me to say <img src="blabla"> instead of just <img>, so I thought the <iframe> was simpler. Do you think the test makes more sense if it uses <img> instead of <iframe>? Simon, do you want me to use img instead of iframe even though I'll have to include a dummy image in the test? Created attachment 225272 [details]
Patch
Looks like I can get around needing an actual image by setting the height and width on the img tag. So here it is with an img tag instead of the iframe.
Comment on attachment 225272 [details] Patch Clearing flags on attachment: 225272 Committed r164743: <http://trac.webkit.org/changeset/164743> All reviewed patches have been landed. Closing bug. |