Summary: | [JS] Convert Promise.prototype.catch to be a built-in | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Sam Weinig
2014-02-19 10:57:37 PST
Created attachment 224656 [details]
Patch
Comment on attachment 224656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224656&action=review > Source/JavaScriptCore/builtins/Promise.prototype.js:33 > + var then = this.then; > + if (typeof then !== "function") > + throw new @TypeError("Promise.prototype.catch requires that |onRejected| be a function"); > + > + return then.@call(this, undefined, onRejected); return this.then(undefined, onRejected); Created attachment 224677 [details]
Patch
Comment on attachment 224677 [details]
Patch
r=me
Comment on attachment 224677 [details] Patch Clearing flags on attachment: 224677 Committed r164396: <http://trac.webkit.org/changeset/164396> All reviewed patches have been landed. Closing bug. |