Bug 129052

Summary: [JS] Convert Promise.prototype.catch to be a built-in
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sam Weinig
Reported 2014-02-19 10:57:37 PST
[JS] Convert Promise.prototype.catch to be a built-in
Attachments
Patch (6.80 KB, patch)
2014-02-19 11:00 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (6.63 KB, patch)
2014-02-19 14:32 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2014-02-19 11:00:02 PST
Created attachment 224656 [details] Patch
Geoffrey Garen
Comment 2 2014-02-19 12:15:59 PST
Comment on attachment 224656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224656&action=review > Source/JavaScriptCore/builtins/Promise.prototype.js:33 > + var then = this.then; > + if (typeof then !== "function") > + throw new @TypeError("Promise.prototype.catch requires that |onRejected| be a function"); > + > + return then.@call(this, undefined, onRejected); return this.then(undefined, onRejected);
Sam Weinig
Comment 3 2014-02-19 14:32:10 PST
Created attachment 224677 [details] Patch
Geoffrey Garen
Comment 4 2014-02-19 14:47:32 PST
Comment on attachment 224677 [details] Patch r=me
WebKit Commit Bot
Comment 5 2014-02-19 15:26:10 PST
Comment on attachment 224677 [details] Patch Clearing flags on attachment: 224677 Committed r164396: <http://trac.webkit.org/changeset/164396>
WebKit Commit Bot
Comment 6 2014-02-19 15:26:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.