Bug 129038

Summary:

[EFL] Update glib version to the newest in EFL.

Product:

WebKit

Reporter:

László Langó <llango.u-szeged>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

gyuyoung.kim, lucas.de.marchi, ossy, ryuan.choi

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	gyuyoung.kim: review-, gyuyoung.kim: commit-queue-

László Langó

Reported 2014-02-19 04:07:53 PST

Current version is 2.36.0, this is almost one year old. We should update this.

Attachments
Patch (1.37 KB, patch) 2014-02-19 04:12 PST, László Langó	gyuyoung.kim: review- gyuyoung.kim: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

László Langó

Comment 1 2014-02-19 04:12:39 PST

Created attachment 224621 [details] Patch

Gyuyoung Kim

Comment 2 2014-02-19 05:23:00 PST

Comment on attachment 224621 [details] Patch I don't mind to use the newest glib if there is no issue with EFL libraries. Ryuan, do you know any issue on the latest glib ?

Ryuan Choi

Comment 3 2014-02-19 05:57:04 PST

(In reply to comment #2) > (From update of attachment 224621 [details]) > I don't mind to use the newest glib if there is no issue with EFL libraries. Ryuan, do you know any issue on the latest glib ? No, in fact, I don't follow it. Anyway, we'd better to use same version of glib with gtk, my two cents. GTK port now uses 2.38.

Gyuyoung Kim

Comment 4 2014-02-19 23:31:16 PST

(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 224621 [details] [details]) > > I don't mind to use the newest glib if there is no issue with EFL libraries. Ryuan, do you know any issue on the latest glib ? > > No, in fact, I don't follow it. > > Anyway, we'd better to use same version of glib with gtk, my two cents. > GTK port now uses 2.38. If there is no issue when we run the layout test on EFL and we don't know any issue about it, can't we use the latest glib ?

László Langó

Comment 5 2014-02-21 06:26:05 PST

(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 224621 [details] [details] [details]) > > > I don't mind to use the newest glib if there is no issue with EFL libraries. Ryuan, do you know any issue on the latest glib ? > > > > No, in fact, I don't follow it. > > > > Anyway, we'd better to use same version of glib with gtk, my two cents. > > GTK port now uses 2.38. > > If there is no issue when we run the layout test on EFL and we don't know any issue about it, can't we use the latest glib ? I cannot check this on my machine, I have a lot of Layout test issues without the patch too. Much more than the bots show. Maybe because I use Ubuntu 12.04, but the bot use 13.04. So my comparison before and after the glib update is irrelevant. :( I have ~3K test failures.

Gyuyoung Kim

Comment 6 2014-02-22 02:08:07 PST

Comment on attachment 224621 [details] Patch Yes, I ran EFL layout test locally. There are a lot of failing tests on the newest glib. r- because of the fails. We can't update it until fixing those failings.

Csaba Osztrogonác

Comment 7 2014-05-27 04:34:14 PDT

Now EFL uses the same glib version (2.38) as GTK: http://trac.webkit.org/changeset/166403 I don't think if we want to update 2.39 now.

Note You need to log in before you can comment on or make changes to this bug.