| Summary: | [EFL] Update glib version to the newest in EFL. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | László Langó <llango.u-szeged> | ||||
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED WONTFIX | ||||||
| Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, ossy, ryuan.choi | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
László Langó
2014-02-19 04:07:53 PST
Created attachment 224621 [details]
Patch
Comment on attachment 224621 [details]
Patch
I don't mind to use the newest glib if there is no issue with EFL libraries. Ryuan, do you know any issue on the latest glib ?
(In reply to comment #2) > (From update of attachment 224621 [details]) > I don't mind to use the newest glib if there is no issue with EFL libraries. Ryuan, do you know any issue on the latest glib ? No, in fact, I don't follow it. Anyway, we'd better to use same version of glib with gtk, my two cents. GTK port now uses 2.38. (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 224621 [details] [details]) > > I don't mind to use the newest glib if there is no issue with EFL libraries. Ryuan, do you know any issue on the latest glib ? > > No, in fact, I don't follow it. > > Anyway, we'd better to use same version of glib with gtk, my two cents. > GTK port now uses 2.38. If there is no issue when we run the layout test on EFL and we don't know any issue about it, can't we use the latest glib ? (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 224621 [details] [details] [details]) > > > I don't mind to use the newest glib if there is no issue with EFL libraries. Ryuan, do you know any issue on the latest glib ? > > > > No, in fact, I don't follow it. > > > > Anyway, we'd better to use same version of glib with gtk, my two cents. > > GTK port now uses 2.38. > > If there is no issue when we run the layout test on EFL and we don't know any issue about it, can't we use the latest glib ? I cannot check this on my machine, I have a lot of Layout test issues without the patch too. Much more than the bots show. Maybe because I use Ubuntu 12.04, but the bot use 13.04. So my comparison before and after the glib update is irrelevant. :( I have ~3K test failures. Comment on attachment 224621 [details]
Patch
Yes, I ran EFL layout test locally. There are a lot of failing tests on the newest glib. r- because of the fails. We can't update it until fixing those failings.
Now EFL uses the same glib version (2.38) as GTK: http://trac.webkit.org/changeset/166403 I don't think if we want to update 2.39 now. |