Bug 129030

Summary: [WK2] IPC callback classes should not be tightly coupled to C API
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, berto, cgarcia, commit-queue, eric.carlson, glenn, gustavo, jer.noble, mrobinson, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
proposed patch andersca: review+

Alexey Proskuryakov
Reported 2014-02-18 23:10:34 PST
Currently, CallbackBase subclasses call result functions with C API objects as arguments. This causes very roundabout code in cases where we provide the results to Objective C or Gtk APIs - we first create C API objects, and then unwrap them.
Attachments
proposed patch (84.64 KB, patch)
2014-02-18 23:18 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed patch (83.90 KB, patch)
2014-02-18 23:38 PST, Alexey Proskuryakov 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-02-18 23:18:28 PST
Created attachment 224598 [details] proposed patch
WebKit Commit Bot
Comment 2 2014-02-18 23:20:34 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alexey Proskuryakov
Comment 3 2014-02-18 23:38:34 PST
Created attachment 224599 [details] proposed patch
Anders Carlsson
Comment 4 2014-02-19 16:42:10 PST
Comment on attachment 224599 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=224599&action=review > Source/WebKit2/UIProcess/WebPageProxy.h:233 > + typedef std::function<void(bool, const WebCore::IntPoint&, uint32_t, uint32_t, uint32_t)> CallbackFunction; Missing space between void and (
Alexey Proskuryakov
Comment 5 2014-02-19 19:16:31 PST
Committed <http://trac.webkit.org/r164409>.
Note You need to log in before you can comment on or make changes to this bug.