Summary: | [WK2] IPC callback classes should not be tightly coupled to C API | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
Component: | WebKit2 | Assignee: | Alexey Proskuryakov <ap> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, berto, cgarcia, commit-queue, eric.carlson, glenn, gustavo, jer.noble, mrobinson, philipj, sergio | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2014-02-18 23:10:34 PST
Created attachment 224598 [details]
proposed patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Created attachment 224599 [details]
proposed patch
Comment on attachment 224599 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=224599&action=review > Source/WebKit2/UIProcess/WebPageProxy.h:233 > + typedef std::function<void(bool, const WebCore::IntPoint&, uint32_t, uint32_t, uint32_t)> CallbackFunction; Missing space between void and ( Committed <http://trac.webkit.org/r164409>. |