Summary: | StyleResolver::loadPendingImage() should take a reference to StylePendingImage | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | CSS | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | allan.jensen, andersca, commit-queue, darin, ddkilzer, esprehn+autocc, glenn, gyuyoung.kim, kling, koivisto, macpherson, menard, oliver | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 128671 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2014-02-18 20:11:43 PST
Created attachment 224580 [details]
Patch v1
Comment on attachment 224580 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=224580&action=review r=me > Source/WebCore/css/StyleResolver.cpp:3495 > + if (CSSImageSetValue* imageSetValue = pendingImage.cssImageSetValue()) Shouldn't this just be 'auto imageSetValue', too? Committed r164489: <http://trac.webkit.org/changeset/164489> (In reply to comment #2) > (From update of attachment 224580 [details]) > > Source/WebCore/css/StyleResolver.cpp:3495 > > + if (CSSImageSetValue* imageSetValue = pendingImage.cssImageSetValue()) > > Shouldn't this just be 'auto imageSetValue', too? I also fixed this while I was in the neighborhood. Thanks! |