Bug 129009

Summary: Add more new SPI methods
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Anders Carlsson
Reported 2014-02-18 16:20:10 PST
Add more new SPI methods
Attachments
Patch (3.28 KB, patch)
2014-02-18 16:21 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (3.08 KB, patch)
2014-02-18 16:22 PST, Anders Carlsson 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-02-18 16:21:46 PST
Created attachment 224563 [details] Patch
Anders Carlsson
Comment 2 2014-02-18 16:22:25 PST
Created attachment 224564 [details] Patch
WebKit Commit Bot
Comment 3 2014-02-18 16:25:12 PST
Attachment 224564 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:57: Missing spaces around = [whitespace/operators] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 4 2014-02-18 16:25:22 PST
Comment on attachment 224564 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224564&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:510 > + return !applicationName ? nil : (NSString *)applicationName; why not flip this? it reads better that way, imo. also, do you actually need this explicit cast?
Anders Carlsson
Comment 5 2014-02-18 16:30:56 PST
Committed r164330: <http://trac.webkit.org/changeset/164330>
Note You need to log in before you can comment on or make changes to this bug.