Bug 128986

Summary: AX: Searching for "immediate descendants only" can return unexpected results.
Product: WebKit Reporter: Samuel White <samuel_white>
Component: AccessibilityAssignee: Samuel White <samuel_white>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, eric.carlson, glenn, jcraig, jdiggs, jer.noble, mario, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.9   
Attachments:
Description Flags
Patch.
none
Updated patch. none

Description Samuel White 2014-02-18 11:37:14 PST 
Distant descendant results are occasionally sneaking in. We are missing an application of the immediateDescendantsOnly flag during our DFS.
Comment 1 Radar WebKit Bug Importer 2014-02-18 11:37:52 PST 
<rdar://problem/16100054>
Comment 2 Radar WebKit Bug Importer 2014-02-18 11:37:53 PST 
<rdar://problem/16100055>
Comment 3 Samuel White 2014-02-18 11:38:53 PST 
We should also update the test to ensure fast search results match traditional children results (when appropriate).
Comment 4 Radar WebKit Bug Importer 2014-02-18 11:39:16 PST 
<rdar://problem/16100081>
Comment 5 Samuel White 2014-02-18 11:50:08 PST 
Created attachment 224529 [details]
Patch.
Comment 6 chris fleizach 2014-02-18 13:23:01 PST 
Comment on attachment 224529 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=224529&action=review

> Source/WebCore/ChangeLog:8
> +        Missed an application of the immediateDescendantsOnly during the initial implementation.

what was the application that was missed?
Comment 7 Samuel White 2014-02-18 13:51:59 PST 
Created attachment 224542 [details]
Updated patch.

Updated the commit message to better address your question. Marking for review as the previous patch passed without issue (only ChangeLog changes here). Thanks for looking Chris.
Comment 8 WebKit Commit Bot 2014-02-18 14:34:31 PST 
Comment on attachment 224542 [details]
Updated patch.

Clearing flags on attachment: 224542

Committed r164321: <http://trac.webkit.org/changeset/164321>
Comment 9 WebKit Commit Bot 2014-02-18 14:34:33 PST 
All reviewed patches have been landed.  Closing bug.