Bug 128967

Summary: Move to using std::unique_ptr for VisitedLinkState, CheckedRadioButtons
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, kangil.han
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128007    
Attachments:
Description Flags
Patch
none
Patch kling: review+

Zan Dobersek
Reported 2014-02-18 04:21:11 PST
Move to using std::unique_ptr for VisitedLinkState
Attachments
Patch (7.37 KB, patch)
2014-02-19 13:48 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (7.38 KB, patch)
2014-02-19 14:02 PST, Zan Dobersek 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-02-19 13:48:20 PST
Created attachment 224669 [details] Patch
Zan Dobersek
Comment 2 2014-02-19 14:02:49 PST
Created attachment 224673 [details] Patch
Andreas Kling
Comment 3 2014-02-19 16:10:09 PST
Comment on attachment 224673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224673&action=review r=me > Source/WebCore/dom/CheckedRadioButtons.cpp:189 > + std::unique_ptr<RadioButtonGroup>& group = m_nameToGroupMap->add(element->name().impl(), nullptr).iterator->value; I'd use "auto&" here.
Zan Dobersek
Comment 4 2014-02-20 04:24:43 PST
Committed r164425: <http://trac.webkit.org/changeset/164425>
Note You need to log in before you can comment on or make changes to this bug.