Bug 128967

Summary:

Move to using std::unique_ptr for VisitedLinkState, CheckedRadioButtons

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, kangil.han

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

128007

Attachments:

Description	Flags
Patch	none
Patch	kling: review+

Description Zan Dobersek 2014-02-18 04:21:11 PST

Move to using std::unique_ptr for VisitedLinkState

Comment 1 Zan Dobersek 2014-02-19 13:48:20 PST

Created attachment 224669 [details]
Patch

Comment 2 Zan Dobersek 2014-02-19 14:02:49 PST

Created attachment 224673 [details]
Patch

Comment 3 Andreas Kling 2014-02-19 16:10:09 PST

Comment on attachment 224673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224673&action=review

r=me

> Source/WebCore/dom/CheckedRadioButtons.cpp:189
> +    std::unique_ptr<RadioButtonGroup>& group = m_nameToGroupMap->add(element->name().impl(), nullptr).iterator->value;

I'd use "auto&" here.

Comment 4 Zan Dobersek 2014-02-20 04:24:43 PST

Committed r164425: <http://trac.webkit.org/changeset/164425>