Bug 128959

Summary: [iOS] Web Inspector: JSContext inspection crashes in isMainThread, uninitialized WebCoreWebThreadIsLockedOrDisabled
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, ddkilzer, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2014-02-18 00:24:30 PST
An iOS Application can use JavaScriptCore / JSContext without WebKit. In this path, the WTF WebCoreWebThread functions have not been initialized yet, and isMainThread with USE(WEB_THREAD) assumes it is and calls WebCoreWebThreadIsLockedOrDisabled and causes a crash. We should not assume that the function pointer has been filled in, as will be the case when this is used outside of a web environment.
Attachments
[PATCH] Proposed Fix (2.23 KB, patch)
2014-02-18 00:30 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-02-18 00:25:02 PST
<rdar://problem/16095242>
Joseph Pecoraro
Comment 2 2014-02-18 00:30:18 PST
Created attachment 224478 [details] [PATCH] Proposed Fix
David Kilzer (:ddkilzer)
Comment 3 2014-02-18 11:14:02 PST
Comment on attachment 224478 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 4 2014-02-18 11:45:46 PST
Comment on attachment 224478 [details] [PATCH] Proposed Fix Clearing flags on attachment: 224478 Committed r164301: <http://trac.webkit.org/changeset/164301>
WebKit Commit Bot
Comment 5 2014-02-18 11:45:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.