[iOS] All WebKit clients should encrypt WebCrypto keys automatically

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

We have a client call to get a WebCrypto master key, but most client won't implement it. WebKit should provide encryption by default.

<rdar://problem/16075932>

[Alexey Proskuryakov]

Created attachment 224434 [details]
proposed patch

[Alexey Proskuryakov]

Created attachment 224443 [details]
added fallback to _NSGetProgname

Comment on attachment 224443 [details]
added fallback to _NSGetProgname

View in context: https://bugs.webkit.org/attachment.cgi?id=224443&action=review

> Source/WebCore/crypto/mac/SerializedCryptoKeyWrapMac.mm:78
> +    NSString *applicationName = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleDisplayName"];

Shouldn’t we try to get this from -localizedInfoDictionary first?

Let’s use a local variable for [NSBundle mainBundle].

[Tim Horton]

Comment on attachment 224443 [details]
added fallback to _NSGetProgname

View in context: https://bugs.webkit.org/attachment.cgi?id=224443&action=review

> Source/WebCore/crypto/mac/SerializedCryptoKeyWrapMac.mm:81
> +    NSString *applicationName = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleDisplayName"];
> +    if (!applicationName)
> +        applicationName = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleName"];
> +    if (!applicationName)

plz use constants!

(In reply to comment #3)
> (From update of attachment 224443 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=224443&action=review
> 
> > Source/WebCore/crypto/mac/SerializedCryptoKeyWrapMac.mm:78
> > +    NSString *applicationName = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleDisplayName"];
> 
> Shouldn’t we try to get this from -localizedInfoDictionary first?

Ignore this. -objectForInfoDictionaryKey: returns a localized version.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/r164317>.