Bug 128920

Summary: [GTK] Mark view source mode methods as deprecated
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, berto, commit-queue, gustavo, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Updated patch mrobinson: review+

Carlos Garcia Campos
Reported 2014-02-17 11:25:52 PST
They don't do anything since r164235. All possible solutions I can think of to implement this should be done in the application side. So, I think it's better to deprecated instead of trying to figure out how to re-implement them in webkit without the view source mode in webcore.
Attachments
Patch (6.75 KB, patch)
2014-02-24 01:31 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch (7.68 KB, patch)
2014-02-24 02:58 PST, Carlos Garcia Campos 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-02-24 01:31:16 PST
Created attachment 225044 [details] Patch
WebKit Commit Bot
Comment 2 2014-02-24 01:34:13 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2014-02-24 02:58:02 PST
Created attachment 225049 [details] Updated patch Forgot to add deprecation guards in public header
Carlos Garcia Campos
Comment 4 2014-02-24 23:45:56 PST
Committed r164634: <http://trac.webkit.org/changeset/164634>
Note You need to log in before you can comment on or make changes to this bug.