Summary: | Turn the history client into a fancy API::HistoryClient abstract base class | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Anders Carlsson
2014-02-17 10:48:03 PST
Created attachment 224396 [details]
Patch
Attachment 224396 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/API/C/WKContext.cpp:29: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 224396 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224396&action=review r=me though there's a disgusting amount of asterisks in this code. :| > Source/WebKit2/UIProcess/WebContext.h:223 > + API::HistoryClient& historyClient() { return *m_historyClient; } I'd use this accessor instead of accessing m_historyClient now, since that lets you use . instead of -> Committed r164230: <http://trac.webkit.org/changeset/164230> |