Bug 128915 – Add type-checked casts for StyleImage and subclasses

• Component: CSS
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

Add type-checked casts for StyleImage and its subclasses.

[David Kilzer (:ddkilzer)]

Created attachment 224390 [details]
Patch v1

[Andreas Kling]

Comment on attachment 224390 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=224390&action=review

Sweet patch, just some stylistic comments.

> Source/WebCore/css/CSSCursorImageValue.cpp:198
> +    return toStyleCachedImage(m_image.get())->cachedImage()->url();

Since we're sure that m_image can't be null, I'd write this like so:
return toStyleCachedImage(*m_image).cachedImage()->url();

> Source/WebCore/css/CSSImageSetValue.cpp:64
> +        toStyleCachedImageSet(m_imageSet.get())->clearImageSetValue();

Same here.

> Source/WebCore/css/CSSImageSetValue.cpp:194
> +    CachedResource* cachedResource = toStyleCachedImageSet(m_imageSet.get())->cachedImage();

And here.

> Source/WebCore/css/CSSImageValue.cpp:108
> +    CachedResource* cachedResource = toStyleCachedImage(m_image.get())->cachedImage();

And here.

> Source/WebCore/rendering/style/StyleImage.h:97
> +    TYPE_CASTS_BASE(ToClassName, FromClassName, resource, resource->predicate(), resource.predicate())

Not that it matters much, but "resource" seems like a strange name for what's being passed around here.

[Andreas Kling]

Comment on attachment 224390 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=224390&action=review

Sweet patch, just some stylistic comments.

> Source/WebCore/css/CSSCursorImageValue.cpp:198
> +    return toStyleCachedImage(m_image.get())->cachedImage()->url();

Since we're sure that m_image can't be null, I'd write this like so:
return toStyleCachedImage(*m_image).cachedImage()->url();

> Source/WebCore/css/CSSImageSetValue.cpp:64
> +        toStyleCachedImageSet(m_imageSet.get())->clearImageSetValue();

Same here.

> Source/WebCore/css/CSSImageSetValue.cpp:194
> +    CachedResource* cachedResource = toStyleCachedImageSet(m_imageSet.get())->cachedImage();

And here.

> Source/WebCore/css/CSSImageValue.cpp:108
> +    CachedResource* cachedResource = toStyleCachedImage(m_image.get())->cachedImage();

And here.

> Source/WebCore/rendering/style/StyleImage.h:97
> +    TYPE_CASTS_BASE(ToClassName, FromClassName, resource, resource->predicate(), resource.predicate())

Not that it matters much, but "resource" seems like a strange name for what's being passed around here.

[WebKit Commit Bot]

Comment on attachment 224390 [details]
Patch v1

Clearing flags on attachment: 224390

Committed r164298: <http://trac.webkit.org/changeset/164298>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[David Kilzer (:ddkilzer)]

Addressed style issues in Comment #3 in:

Committed r164310: <http://trac.webkit.org/changeset/164310>