Bug 128909

Summary: Web Inspector: CSS selectors containing a color name shouldn't be considered for color editing
Product: WebKit Reporter: Antoine Quint <graouts>
Component: Web InspectorAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Antoine Quint 2014-02-17 07:08:17 PST 
If you have a CSS selector like #facebook, the #fac part of the selector is recognised as a color in the CSS resource and hovering the string will show a hover menu to edit the text as a color. This doesn't make sense, this type of UI should be reserved for CSS properties.
Comment 1 Radar WebKit Bug Importer 2014-02-17 07:08:59 PST 
<rdar://problem/16083842>
Comment 2 Antoine Quint 2014-02-17 08:44:06 PST 
Created attachment 224378 [details]
Patch
Comment 3 Joseph Pecoraro 2014-02-17 11:02:59 PST 
Comment on attachment 224378 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2014-02-17 11:30:47 PST 
Comment on attachment 224378 [details]
Patch

Clearing flags on attachment: 224378

Committed r164236: <http://trac.webkit.org/changeset/164236>
Comment 5 WebKit Commit Bot 2014-02-17 11:30:49 PST 
All reviewed patches have been landed.  Closing bug.