| Summary: | [GTK] ASSERTION FAILED: hasClass() | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Piotr Grad <piotr.grad> | ||||||||
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED DUPLICATE | ||||||||||
| Severity: | Normal | ||||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Piotr Grad
2014-02-17 05:38:09 PST
Created attachment 224360 [details]
Patch
Comment on attachment 224360 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224360&action=review > Source/WebCore/platform/gtk/RenderThemeGtk.cpp:114 > static bool nodeHasClass(Node* node, const char* className) I think this should take a const Node& since it can never be null (You'd have to change the call sites as well). The same thing is true for nodeHasPseudo but that doesn't have to be in this patch. > Source/WebCore/platform/gtk/RenderThemeGtk.cpp:116 > - return node->isElementNode() ? toElement(node)->classNames().contains(className) : false; > + return (node->isElementNode() && toElement(node)->hasClass()) ? toElement(node)->classNames().contains(className) : false; I think this would look better with early returns, something like: if (!node.isElementNode()) return false; const Element& element = toElement(node); if (!element.hasClass()) return false; return element.classNames().contains(className); Created attachment 224493 [details]
Patch.txt
Comment on attachment 224493 [details] Patch.txt View in context: https://bugs.webkit.org/attachment.cgi?id=224493&action=review > Source/WebCore/platform/gtk/RenderThemeGtk.cpp:122 > + if (!toElement(&node)->hasClass()) > + return false; > + > + return toElement(&node)->classNames().contains(className); As I suggested, please put the element in a local variable here to avoid calling toElement twice (since toElement is a virtual call): const Element& element = toElement(node); (or *toElement(*node) if there's no version that takes references). Created attachment 224517 [details]
Patch
Comment on attachment 224517 [details] Patch duplicate of https://bugs.webkit.org/show_bug.cgi?id=128820 *** This bug has been marked as a duplicate of bug 128820 *** |