Summary: | REGRESSION (r158254): Rubber-banding at Bing image search causes the toolbar to move up and away | ||
---|---|---|---|
Product: | WebKit | Reporter: | mitz |
Component: | DOM | Assignee: | gur.trio |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | andersca, ap, bdakin, buildbot, cmarcelo, commit-queue, darin, dbates, esprehn+autocc, gur.trio, kangil.han, rniwa, simon.fraser, thorton, tonikitoo |
Priority: | P1 | Keywords: | InRadar, Regression |
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
URL: | http://www.bing.com/images/search?q=panda&go=Submit&qs=n&form=QBIR&pq=panda&sc=0-0&sp=-1&sk= | ||
Attachments: |
Description
mitz
2014-02-15 12:31:44 PST
In that case, we need to revert both http://trac.webkit.org/changeset/158254 and http://trac.webkit.org/changeset/154614. These changes are simply not Web compatible. (In reply to comment #2) > In that case, we need to revert both http://trac.webkit.org/changeset/158254 and http://trac.webkit.org/changeset/154614. These changes are simply not Web compatible. Revert this as well http://trac.webkit.org/changeset/156605. (In reply to comment #3) > (In reply to comment #2) > > In that case, we need to revert both http://trac.webkit.org/changeset/158254 and http://trac.webkit.org/changeset/154614. These changes are simply not Web compatible. > > Revert this as well http://trac.webkit.org/changeset/156605. Agreed the middle term solution (body.scrolltop == documentElement.scrollTop) is not ideal. For the record, Blink has also moved away from such a change. It has the exclusive behavior under a runtime flag for now. Do we need to revert all the changes or just http://trac.webkit.org/changeset/158254 which was done to fix https://bugs.webkit.org/show_bug.cgi?id=122882 and partial revert of http://trac.webkit.org/changeset/154614 and http://trac.webkit.org/changeset/156605. (In reply to comment #5) > Do we need to revert all the changes or just http://trac.webkit.org/changeset/158254 which was done to fix https://bugs.webkit.org/show_bug.cgi?id=122882 and partial revert of http://trac.webkit.org/changeset/154614 and http://trac.webkit.org/changeset/156605. We need to revert all changes. Created attachment 225879 [details]
Patch
(In reply to comment #7) > Created an attachment (id=225879) [details] > Patch Sorry for the delay. I tried reverting webkitbot: rollout but that did not work so had to do it manually. Comment on attachment 225879 [details] Patch Attachment 225879 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4875165334765568 New failing tests: http/tests/navigation/anchor-frames.html Created attachment 225883 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 225879 [details] Patch Attachment 225879 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5140268969885696 New failing tests: http/tests/navigation/anchor-frames.html Created attachment 225886 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 225879 [details] Patch Attachment 225879 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6139844224876544 New failing tests: http/tests/navigation/anchor-frames.html Created attachment 225889 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 225948 [details]
Patch
Comment on attachment 225948 [details]
Patch
There might be a chance to try again this change when Blink moves on and enabled this switch.
Comment on attachment 225948 [details] Patch Clearing flags on attachment: 225948 Committed r165185: <http://trac.webkit.org/changeset/165185> All reviewed patches have been landed. Closing bug. |